[PWGJE] modify the delta pT methods to except the zero jet evnets#14476
[PWGJE] modify the delta pT methods to except the zero jet evnets#14476nzardosh merged 3 commits intoAliceO2Group:masterfrom
Conversation
Hamwooseok
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
|
@aimeric-landou are you ok with these changes? |
|
@nzardosh @Hamwooseok I am ok with these changes. |
|
@nzardosh The build process has not completed for more than a week. Is there anything on my side that I should fix or take care of? |
As it states in the pending checks, they will not start before the PR is approved. |
Thank you! I understood it. |
fjonasALICE
left a comment
fjonasALICE
left a comment
There was a problem hiding this comment.
hi I have a small suggestion for a change, then i will approve to trigger the test
| if (std::sqrt(dEta * dEta + dPhi * dPhi) < randomConeR) { | ||
| randomConePt += track.pt(); | ||
| if (jets.size() > 0) { // Since the purpose of the fluctuation measurement is jet correction, events with zero accepted jets (from the jetfinder cuts) are excluded | ||
| TRandom3 randomNumber(0); |
There was a problem hiding this comment.
please don't initialise the random number generator every time again. Make it a part of your task struct and initialise it there as a pointer and then rall here only randomNumber.Uniform(....)
There was a problem hiding this comment.
Thank you for comment, I added task structure and removed the TRandom3 inside the if state. Please check it and let me know there are problem.
…ify the position of random number generator
…iceO2Group#14476) Co-authored-by: Wooseok Ham <ham@Wooseokui-MacBookPro-298.local>
5 participants
I understood that the previously requested modification (excluding events without jets in the delta pT calculation) had been implemented; however, it appears that this was not reflected, so I am submitting this again.
In addition, I have incorporated the newly requested change (moving the TRandom3 function inside the if statement). Accordingly, instead of inserting an if statement separately for each delta pT method, I have applied a single if statement that covers all methods.